Skip to content

Simplify AOE / template construction#832

Merged
unbohn merged 11 commits into
isofit:devfrom
pgbrodrick:aoe_simplify
Feb 6, 2026
Merged

Simplify AOE / template construction#832
unbohn merged 11 commits into
isofit:devfrom
pgbrodrick:aoe_simplify

Conversation

@pgbrodrick

@pgbrodrick pgbrodrick commented Jan 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

This PR pulls together a few updates:

  • Function consolidation in template_construction (this was the original PR purpose). Necessarily, some updates to apply_oe are included.
  • Adds terrain_style option to apply_oe, and into the radiative_transfer config. While I'd prefer this live in forward_model, it's hard to access in the critical location. I left hooks in for a statevector solution, but we need changes to the analytical_line for that to work.
  • Small updates to data.py to avoid SLL cert issues.

@pgbrodrick pgbrodrick marked this pull request as ready for review January 30, 2026 23:52
@pgbrodrick pgbrodrick requested review from jammont and unbohn and removed request for jammont and unbohn January 30, 2026 23:52
@pgbrodrick

pgbrodrick commented Jan 31, 2026

Copy link
Copy Markdown
Collaborator Author

@jammont, let me know if you're okay with the change to data.py. I had to make this to get past SSL cert issues with downloads, but it's separate from the other changes in this PR.

unbohn
unbohn reviewed Feb 2, 2026
View reviewed changes
Comment thread isofit/utils/apply_oe.py
unbohn
unbohn reviewed Feb 2, 2026
View reviewed changes
Comment thread isofit/utils/apply_oe.py
unbohn
unbohn reviewed Feb 2, 2026
View reviewed changes
Comment thread isofit/utils/apply_oe.py
unbohn
unbohn reviewed Feb 2, 2026
View reviewed changes
Comment thread isofit/utils/template_construction.py
@unbohn

unbohn commented Feb 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

@pgbrodrick This looks great! Except for some very minor comments (see above), it's ready for merge from my point of view.

@evan-greenbrg evan-greenbrg mentioned this pull request Feb 2, 2026
Closed
@pgbrodrick

pgbrodrick commented Feb 2, 2026

Copy link
Copy Markdown
Collaborator Author

Thanks for the review @unbohn . This PR is now deprecated, as it has been merged into #830 for additional testing.

@unbohn unbohn merged commit d7afae4 into isofit:dev Feb 6, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@unbohn unbohn unbohn approved these changes

@jammont jammont Awaiting requested review from jammont

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pgbrodrick @unbohn