Glint model updates#750
Merged
Merged
Conversation
unbohn
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three updates included here:
surface_config.pyfit_paramsfrom the NIR alone in extremely turbid cases or cases with bottom reflectance could overestimate glint and drive the initial reflectance into the negative/0. This caused issues with the inversion. I added a NIR/SWIR check as well as a check at blue wavelengths to make sure reflectance at short wavelengths isn't negative.self.initComparison between the two sun glint intensity prior strategies:
