Srtm/6c#717
Conversation
|
The offending issue is here: This product clearly won't work in 4c radiance mode, only 4c transmittance. |
| # Keep transmittances as transmitance, but convert coupling terms to radiance | ||
| # TODO - get rhoatm out of this list. Probably easiest to implement a bulk | ||
| # rt_mode purge | ||
| for key in ["dir-dir", "dir-dif", "dif-dir", "dif-dif", "rhoatm"]: |
There was a problem hiding this comment.
Is it worth renaming these ("dir-dir") to "Ldir-dir", etc?
There was a problem hiding this comment.
We could, we'd have to link that change to what's in RTE right now as well, as that's where the coupling is defined...this just matches that nomenclature.
|
Out of the box, simulations on the 6c emulator were taking an extremely long time: Working this morning to confirm what the root cause is. Need to check if it's in the code or something on my end. |
|
Hmm, how big is your LUT? I'm seeing numbers that look more like this: INFO:2025-06-19,14:54:31 || common.py:call() | 20.06% simulations complete (elapsed: 0:00:17.743084, rate: 0:00:00.012802, eta: 0:01:10.972336) For a LUT that looks like this: There's definitely room for optimization (e.g. parallelize deployment over different keys), and I do expect this PR to take longer than before no matter what (we're building close to an order of magnitude more outputs), but the above looks like it's way too slow....almost like it's before I included the updates to utilize the cached H matrix. |
|
Current emulators FOR TESTING ONLY - NOT OFFICIAL: https://popo.jpl.nasa.gov/pub/PBrodrick/isofit/experimental/joint_dataset_wpoints/ |
|
Thank you Phil! FYI, using *26.npz I'm getting the error: |
Did you pull the file fresh today? It was reposted in-place (with the same name). That error will occur with the previous packed version of the .npz. |
jammont
left a comment
There was a problem hiding this comment.
Just a few fairly minor comments. Looks pretty good.
| from isofit.utils import surface_model | ||
|
|
||
|
|
||
| # TODO - re-engage this test w/ 6c emulator & new glint model |
There was a problem hiding this comment.
When will this test be re-enabled?
There was a problem hiding this comment.
Agreed this should happen, but I don't think it's necessary in this PR (it will take some work, and we should wait for an official sRTMnet 6c model posting.
|
This is ready to go into |


To replace #662. To be merged after #713.