heuristic patch#706
Merged
Merged
Conversation
evan-greenbrg
approved these changes
Jun 2, 2025
evan-greenbrg
left a comment
Collaborator
There was a problem hiding this comment.
Great catch. The issue was clear as day as soon as you pointed out the code block. Short term if statement looks fine to me. It's in line with how we handle 1c vs 4c throughout.
I agree that populating the return from RT.get_shared_rtm_quantities in 1c vs 4c case should be made more robust. There should be a way to structure the returning dict in a way where the risk of divide by zero errors are minimized.
Collaborator
|
Thanks for catching this, @pgbrodrick! Important patch, merging now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a stopgap patch to address #705.
A better solution would be to leverage RT.calc_RT_quantities, but this serves to get us back operating in the short term.