Cleaning out of date comments#693
Merged
Merged
Conversation
evan-greenbrg
commented
May 15, 2025
Collaborator
Author
There was a problem hiding this comment.
This is currently commented out, but I want to bring it back to attention. How should we formalize negative/out of bounds reflectance? We should remove this code block if we want to keep the AL unconstrained in the output.
L470 analytical_line.py
# What do we want to do with the negative reflectances?
# state = output_state[r - start_line, ...]
# mask = np.logical_and.reduce(
# [
# state < self.rfl_bounds[0],
# state > self.rfl_bounds[1],
# state != -9999,
# state != -0.01,
# ]
# )
# state[mask] = 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some spring cleaning of code that I've been responsible for.
This primarily removes/fleshes out comments that reflected past iterations of the glint model.