Added coupled transm to heurstic atmosphere#686
Merged
Conversation
unbohn
approved these changes
May 9, 2025
Collaborator
|
Thanks for this catch, @evan-greenbrg! It's an important fix. File changes are reasonable and clear, tests have passed, so I'll merge right away. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a potential bug in the heursitic_atmosphere function when using the full 4c radiance model.
Currently, the
transmvariable in the function is initialized only with the downwards components:Regardless if this is the behavior we want, it is inconsistent with the 1c implementation where the populated
transmLUT variable contains the full coupled transmittance spectrum. To make this consistent:First pass tests show that this fixes the initial issue of poor water vapor retrievals with the 4c model: