rte_configure_and_exit Skip LUT Creation#683
Merged
Merged
Conversation
pgbrodrick
reviewed
May 9, 2025
Collaborator
|
Thanks James! This looks great...I don't actually think there's another exit call after the RTE build (unless I missed it)...do you think it would be reasonable to add one where I marked above, after the json's are built? That way we don't try and do the inversions (which won't succeed)... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does as the title suggests, just skips creating the LUT file when
engine_config.rte_configure_and_exitis set. Tad invasive of an implementation due to the need to still allow the entirety ofrunSimulationsto execute depending on where engines may write configuration files (ie.pre,make, orpostSimfunctions), so we have toif self.engine_config.rte_configure_and_exitmultiple times to skip certain lines. Not sure if there's a more graceful solution.Needs some further testing
Closes #681