swap path for csv#670
Merged
Merged
Conversation
jammont
approved these changes
Apr 21, 2025
jammont
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for tackling this! Looks great, greatly appreciate submitting a PR to isofit-data as well
| # __file__ should live at isofit/isofit/inversion/ | ||
| isofit_path = os.path.dirname(os.path.dirname(os.path.dirname(__file__))) | ||
| path_k = os.path.join(isofit_path, "data", "iop", "k_liquid_water_ice.xlsx") | ||
| path_k = os.path.join(isofit_path, "data", "iop", "k_liquid_water_ice.csv") |
Collaborator
There was a problem hiding this comment.
This line looks to be out of date and won't actually find the file correctly (no fault of this PR). If you could, please change from:
isofit_path = os.path.dirname(os.path.dirname(os.path.dirname(__file__)))
path_k = os.path.join(isofit_path, "data", "iop", "k_liquid_water_ice.csv")to
from isofit.data import env
path_k = env.path("data", "iop", "k_liquid_water_ice.csv")the import goes at the top of the file
Contributor
Author
|
Thank you James for your comments on the data path. I tested EWT utility for both the original and updated CSV file and got near identical results (mean residual ~1e-8). I believe the data just needs to be merged in before this can be. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #576 , by saving the refractive index of water Excel file to a CSV.
I've opened up a similar pull request in ISOFIT-Data that brings in this new file.