Patch to run calibration cases with new surface structure#668
Merged
Conversation
Added surface handling for mis-match shape and test case
Changed test to reflect new file names Make surface model check exclusive Removed exception in calibration surface_model check Revert "Changed test to reflect new file names" This reverts commit edbc8e8. Revert "Removed exception in calibration surface_model check" This reverts commit 2ed9aa2. Working test and fixed bad push
8ee537a to
969eee8
Compare
Collaborator
|
Excellent, thanks for pushing this through! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Related tutorial PR: isofit/isofit-tutorials#18
Tests are currently failing because the new calibration pytest is grouped with
_examples.