Warn if LUT keys are close to known geometry keys#664
Merged
Conversation
added 2 commits
April 7, 2025 13:29
… geometry keys list and outputs a warning if so
Collaborator
|
Thanks! Is the logic behind the 80% match to be fuzzy on syntax? And....do we want that, or should we force things to be exact? I assume from the implementation you had a case in mind, can you elaborate? |
Collaborator
Author
|
Yes, I made it fuzzy so that we can attempt to detect close to but not exact keys in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses an issue in #602 where a LUT had the key
surface_elevationbut ISOFIT expects it to be namedsurface_elevation_km. This PR implements a function incore/common.pyto compare LUT keys with the known geometry keys and if there's an 80% match, output a warning to the user to possibly change it