Fix incorrect calls to ForwardModel.calc_rdn()#656
Merged
Conversation
barentsen
commented
Mar 23, 2025
Collaborator
|
Great catch, and good general suggestion. @unbohn , if you agree, let's get this merged in. |
Collaborator
|
Absolutely agreed! Thanks for the catch @barentsen. @pgbrodrick Please go ahead and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #524,
ForwardModel.calc_rdn()was updated to takerho_dir_dirandrho_dif_dirinstead of a singlerflargument:isofit/isofit/core/forward.py
Line 189 in d9a5112
However,
ForwardModel.calc_meas()wasn't updated accordingly and still passes a singlerflarg tocalc_rdn:isofit/isofit/core/forward.py
Line 215 in d9a5112
As a result, any output relying on
calc_meas-- such as radiometry_correction_file, path_radiance_file, and modeled_radiance_file -- appear to contain incorrect values.We may want to use named arguments in function calls throughout ISOFIT to make bugs like this impossible.