Skip to content

Raise Bad Config Checking#653

Merged
pgbrodrick merged 8 commits into
isofit:devfrom
jammont:qol/configs
Sep 8, 2025
Merged

Raise Bad Config Checking#653
pgbrodrick merged 8 commits into
isofit:devfrom
jammont:qol/configs

Conversation

@jammont

@jammont jammont commented Mar 17, 2025

Copy link
Copy Markdown
Collaborator

Awhile back we had an issue where some downstream checks on the config object weren't being executed due to upstream config sections having a bug that would be caught by this try/except block and then skipped. Ideally, we want those exceptions to be raised so they can be noticed and fixed by devs.

@jammont jammont added the bugfix Fixing an error label Mar 17, 2025
@jammont jammont requested a review from pgbrodrick March 17, 2025 20:01
Comment thread isofit/configs/sections/surface_config.py Outdated
Comment thread isofit/configs/sections/surface_config.py Outdated
@pgbrodrick pgbrodrick merged commit c47b001 into isofit:dev Sep 8, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Fixing an error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants