Downloaders Bugfixes#648
Merged
Merged
Conversation
… error output on the make
Collaborator
|
Thanks for these fixes, @jammont! I quickly scanned the respective conversation on Slack, so am aware of the underlying issues. This PR looks good to go from my perspective. |
unbohn
approved these changes
Mar 10, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a few issues with the downloader modules when working with a user to fix their installation:
isofit download sixswas broken due to having the wrong parametersmakecall, hopefully future errors will be outputted rather than quietly being discardedisofit download imagecubebroken when using a non-default path.DS_Storein every directory to casually pollute users' systems which was causing issues with our examples buildingThe user's issue had to do with their Mac system not having xtools installed correctly. Took a bit of debugging to discover and resolve, so this PR is an attempt to help notice these problems in the future
Closes #649