Reformatted fm.K, removed drdn_dsurface from fm.drdn_dRT and handle drdn_dsurface in surface models#641
Closed
evan-greenbrg wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
|
Note: Should all be included in #637. Should merge that and close this.. |
Collaborator
Author
|
This will be included w/in #637 if implemented. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #637
Objective: To remove explicit handling of particular surfaces in the function
RT.drdn_dRT. We were previously handling explicit surface cases in anifstatement.It ended up being a more involved change. Now all handling of derivative construction is relegated to
fm.Kwhere the function now accumulates necessaryRTandSurfacequantities, passes them to the correspondingRTandsurfacefunctions to construct the K matrix. Ideally, we wouldn't have to awkwardly pass surface vectors back into the surface module, but: #642. This should be abstracted to the point where if one wanted to create a new surface, or alter the derivatives within a particular surface, they can do so by only accessing the surface file itself.I also moved the check_coszen_and_cos_i function into the geom class. This was originally so I could call it in surface models, but now I limit the calls to
fmandRTso this change can be walked back,I've tested with all surface types except
surface_lutbecause I don't have a test case.1:1 tests for the 4 surfaces I could test: The delta is the difference between these updates and dev results. Also, this is from the full pixel inversion not the analytical solution.
