Skip to content

Missing skyview_factor default in isofit.utils.template_construction.Pathnames. #774

@danschef

Description

@danschef

Small issue and probably, I am the only who runs into this, because I am calling isofit.utils.template_construction.Pathnames directly in EnPT:
#735 implemented a new skyview_factor in isofit 3.5.1. It is set to None by default in apply_oe (

skyview_factor=None,
) but in Pathnames, there is no default set ( ), i.e., simply updating isofit from 3.4.3 to 3.5.1 breaks the implementation in EnPT which does not yet set the skyview_factor when calling Pathnames.

Setting skyview_factor=None in Pathnames would fix it. However, all the other parameters of Pathnames are also implemented without defaults, so you I guess you need to decide if it makes sense to add them all there.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions