Merged
Conversation
Adding gdpr_applies, consent_type, and addtl_consent to Rubicon and AppNexus Prebid Server RTC strings as followup to #30006. Adding @SyntaxNode as FYI for AppNexus.
This reverts commit 017c5a8.
`amp-*.js` binaries for Bento-compatible extensions provide an `<amp-*>` element that can be used **with** `v0.js`, and a `<bento-*>` element that can be used **without** `v0.js`. We'd like that Bento elements are used from `bento-*.js` in Bento mode. This unblocks release since we'll be able to include the scripts in Bento mode using the correct URL. Eventually, this binary will only provide the Bento element, while `amp-*.js` will provide only an AMP element. In the meantime, we alias the multiple-compatibility binary so that `bento-*.js` can be used as soon as possible.
…f class (#35861) * Changed classes for template attr * Simplified rules * Fixed some comments * Remove unused template * Reverted pan demo to image * Removed unused const
* Added CTA Migration page-outlink experiment, added logic to have it load during the Promise chain in the layout callback * fixed some circleCI errors * fixed some nits * refactored cta migration and added non-hardcoded values * fixed cricleci spacing issues * fixed cricleci spacing issues * Added description and re-comtting due to circleCI * Added description and re-comtting due to circleCI * Fixed more code review nits * Fixed layout callback unit test * Added back in code-breaking refactor * will open new PR to fix page-attachment prod bug * fixed main merge * renamed the expirement to make it clear it was associated with ads
* create centralized hooks for onLoad/onLoading/onError in PreactBaseElement * update instances where components used their own (similar) hooks * toggle placeholders for bento components with dynamic content * update storybook stories to demonstrate placeholders/fallbacks * update closure typings * update docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.