Skip to content

Update fork#2

Merged
ishaba merged 9 commits intoishaba:mainfrom
ampproject:main
Sep 2, 2021
Merged

Update fork#2
ishaba merged 9 commits intoishaba:mainfrom
ampproject:main

Conversation

@ishaba
Copy link
Copy Markdown
Owner

@ishaba ishaba commented Sep 2, 2021

No description provided.

bretg and others added 9 commits September 1, 2021 16:59
Adding gdpr_applies, consent_type, and addtl_consent to Rubicon and AppNexus Prebid Server RTC strings as followup to #30006.

Adding @SyntaxNode as FYI for AppNexus.
`amp-*.js` binaries for Bento-compatible extensions provide an `<amp-*>` element that can be used **with** `v0.js`, and a `<bento-*>` element that can be used **without** `v0.js`.

We'd like that Bento elements are used from `bento-*.js` in Bento mode. This unblocks release since we'll be able to include the scripts in Bento mode using the correct URL.

Eventually, this binary will only provide the Bento element, while `amp-*.js` will provide only an AMP element. In the meantime, we alias the multiple-compatibility binary so that `bento-*.js` can be used as soon as possible.
…f class (#35861)

* Changed classes for template attr

* Simplified rules

* Fixed some comments

* Remove unused template

* Reverted pan demo to image

* Removed unused const
* Added CTA Migration page-outlink experiment, added logic to have it load during the Promise chain in the layout callback

* fixed some circleCI errors

* fixed some nits

* refactored cta migration and added non-hardcoded values

* fixed cricleci spacing issues

* fixed cricleci spacing issues

* Added description and re-comtting due to circleCI

* Added description and re-comtting due to circleCI

* Fixed more code review nits

* Fixed layout callback unit test

* Added back in code-breaking refactor

* will open new PR to fix page-attachment prod bug

* fixed main merge

* renamed the expirement to make it clear it was associated with ads
* create centralized hooks for onLoad/onLoading/onError in PreactBaseElement

* update instances where components used their own (similar) hooks

* toggle placeholders for bento components with dynamic content

* update storybook stories to demonstrate placeholders/fallbacks
* update closure typings
* update docs
@ishaba ishaba merged commit 79fe36e into ishaba:main Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants