Fix Regression #977 - Web not registering DateTimeAdapter#983
Conversation
Regression was caused in isar#956 (4dbcd76) where `HiveImpl` no longer called `_registerDefaultAdapters`, assuming that it would happen in `init`, which is not necessary for web. Also remove `HiveImpl.debug` and `HiveImpl.test`. `HiveImpl.test` was masking some odd legacy behavior in tests, so this fixes the test. `HiveImpl.debug` is not used anywhere, and its funcationality can be accomplished using `init`
|
@themisir @TheOneWithTheBraid Would be good to send out a patch to pub.dev as the last usable version on web is |
|
Hey @shroff thanks for the contribution and I'm very sorry for breaking stability of hive 🙁 |
|
cc @TheOneWithTheBraid: do you have any comments on this? I'm not sure if this change would conflict with your changes or not, so wanted to check with you before merging. |
|
Indeed, this makes sense. Sorry for breaking this. |
|
Let me quickly check whether it interferes with backend overrides... |
Sure, no need to rush. |
|
LGTM |
Cool, thanks! |
|
No worries! Thanks for your great work on maintaining hive and keeping it going. If possible, it would be great to publish a hotfix soon. |
Regression was caused in #956 (4dbcd76) where
HiveImplno longercalled
_registerDefaultAdapters, assuming that it would happen ininit, which is not necessary for web.Also remove
HiveImpl.debugandHiveImpl.test.HiveImpl.testwas masking some odd legacy behavior in tests, so thisfixes the test.
HiveImpl.debugis not used anywhere, and its funcationality can beaccomplished using
init