fix: provide fallback backend manager#968
Merged
Merged
Conversation
themisir
approved these changes
May 18, 2022
themisir
left a comment
Contributor
There was a problem hiding this comment.
LGTM, but tests seems to be failing (seems like there's missing adapter)
- remove need for manual `Hive.init()` call - provide default backend manager - fix most tests Fixes: #967 Signed-off-by: TheOneWithTheBraid <the-one@with-the-braid.cf>
6205d64 to
19f8f65
Compare
Author
|
@themisir We should create a release of both Hive and Hive Flutter now. |
Contributor
|
Not really, we didn't changed hive_flutter, I'll just retract previous hive version so hive_flutter will not resolve it next time |
Author
|
I opened a corresponding PR. It's not important anymore, as this PR here removed the need for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hive.init()callFixes: #967
Signed-off-by: TheOneWithTheBraid the-one@with-the-braid.cf