Add fs option to allow passing virtual filesystem#430
Closed
mmkal wants to merge 2 commits intoisaacs:masterfrom
Closed
Add fs option to allow passing virtual filesystem#430mmkal wants to merge 2 commits intoisaacs:masterfrom
mmkal wants to merge 2 commits intoisaacs:masterfrom
Conversation
Owner
|
Thanks, landed and published as 7.2.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #429
This enables passing in a virtual filesystem compatible with the
fsmodule. There are several matching thefsAPI:Example:
Allows usage of
globin lots more places without requiring users to monkey-patch. With this change, glob could be used in the browser, with dropbox, S3, purely in memory like above (useful for testing) and many others.After writing that issue up, I had a look at the code and the change required is very small so I thought I'd just open a PR.