Visual changes, UX tweaks to popup#47
Merged
Merged
Conversation
Icon is now white to play nicer on dark mode
This is a more subjective PR. Changes: 1. Toolbar icon now changes based on system color scheme 2. Toolbar icon (and player icon) is now the actual annotation glyph from YouTube circa 2013 3. Popup now separates raw YouTube data and converted data into accordion sections. 4. Popup has been restyled, now supports dark mode. 5. Popup copy rewritten for clarity
Owner
|
Looks much nicer! It's especially nice to actually be able to see the icon while using dark mode. Thanks again :) |
Owner
|
Sorry about the delay. The update is now pending review on the Chrome Store. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes