🤖 Isaac Lab Review Bot

Summary

This PR migrates task and contrib modules from deprecated TiledCamera/TiledCameraCfg aliases to the canonical Camera/CameraCfg classes, and updates task state reads and simulation write calls to use explicit indexed APIs. The changes are mechanical find-and-replace operations that appear correct, though one semantic change in the inhand manipulation env removes backend-adaptive write method selection that may have performance implications.

Architecture Impact

Cross-module impact is minimal. The TiledCamera/TiledCameraCfg types were aliases pointing to Camera/CameraCfg, so this is purely a naming cleanup. The changes touch:

• isaaclab_contrib sensors (TacSL visuotactile sensor)
• isaaclab_tasks direct environments (cartpole, shadow_hand, inhand_manipulation)
• isaaclab_tasks manager-based environments (cartpole, dexsuite, pick_place, stack)

The removal of backend-adaptive write methods in inhand_manipulation_env.py changes behavior but shouldn't break functionality since the indexed APIs work across backends.

Implementation Verdict

Ship it — This is a straightforward deprecation cleanup with one minor concern noted below.

Test Coverage

The existing test test_visuotactile_sensor.py is updated to use CameraCfg and provides adequate coverage for the TacSL sensor changes. However, there are no new tests added for the inhand manipulation write method changes. The CI shows isaaclab_tasks tests passing across all 3 shards, which provides confidence the changes don't break functionality.

CI Status

All relevant checks pass:

• ✅ isaaclab_tasks [1/3], [2/3], [3/3]: success
• ✅ isaaclab_contrib: success
• ✅ pre-commit: success
• ✅ environments_training: success

Multiple core tests are skipped but this appears intentional based on the change detection system.

Findings

🔵 Improvement: source/isaaclab_tasks/isaaclab_tasks/direct/inhand_manipulation/inhand_manipulation_env.py:80-84 — Removed backend-adaptive optimization

The original code selected between mask-based writes (preferred by Newton) and indexed writes (preferred by PhysX) based on the physics backend. The new code unconditionally uses indexed writes. While this is functionally correct (indexed APIs work on both backends), it may have minor performance implications on Newton. The original comment stated "Newton prefers mask-based, PhysX prefers indexed" — if this optimization was meaningful, consider documenting why it was removed or whether the indexed path is now universally optimal.

# Before: Adaptive selection based on backend
use_mask = "newton" in self.sim.physics_manager.__name__.lower()
if use_mask:
    self._set_joint_pos_target = self.hand.set_joint_position_target
    ...
else:
    self._set_joint_pos_target = self.hand.set_joint_position_target_index
    ...

# After: Always use indexed
self._set_joint_pos_target = self.hand.set_joint_position_target_index

🔵 Improvement: source/isaaclab_tasks/isaaclab_tasks/manager_based/manipulation/dexsuite/mdp/rewards.py:221 — State access change is correct but verify equivalence

The change from asset.data.root_state_w.torch[:, 3:7] to asset.data.root_link_quat_w.torch is semantically cleaner. However, verify that root_link_quat_w provides the same reference frame as the quaternion component of root_state_w. Based on Isaac Lab conventions, these should be equivalent for the root link, but confirm this doesn't change the orientation tracking reward behavior.

🔵 Improvement: source/isaaclab_tasks/isaaclab_tasks/manager_based/manipulation/pick_place/mdp/observations.py:83-90 — Explicit concatenation is clearer

The change from accessing the compound body_link_state_w to explicitly concatenating body_link_pose_w and body_link_vel_w is clearer and aligns with the PR's goal of using explicit state properties. This is a good change.

🔵 Improvement: source/isaaclab_tasks/docs/CHANGELOG.rst:4 — Changelog entry date appears to be in the future

The changelog entry shows date 2026-04-27 which appears to be a placeholder or future date. This should be updated to the actual merge date. (Same issue in source/isaaclab_contrib/docs/CHANGELOG.rst:4)

🔵 Improvement: source/isaaclab_contrib/docs/README.md:259,291 — Documentation update is complete

The README documentation correctly updates both the import statement and the usage example to use CameraCfg instead of TiledCameraCfg. Good attention to documentation consistency.