feat(dns): allow disabling the built-in DNS server#186
Merged
Conversation
Add dns.enabled (and the IRON_DNS_ENABLED env override), defaulting to true. When disabled, the :53 listen default and the dns.proxy_ip requirement are both skipped, and the DNS server is not started — letting a DNS-less proxy be configured for clients that reach it via explicit HTTP(S)_PROXY settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
dns.enabled(and theIRON_DNS_ENABLEDenv override), defaulting to true so existing behavior is unchanged. Setting it to false skips the:53listen default and thedns.proxy_iprequirement and does not start the DNS server, so iron-proxy can run for clients that reach it via explicitHTTP(S)_PROXYsettings rather than DNS interception.Split out from the Helm chart PR (#185); the chart's
listeners.dns.enabled=falsetoggle depends on this.