feat(controlplane): apply synced transforms in managed pipeline#172
Merged
Conversation
The control plane delivers gcp_auth, hmac_sign, and oauth_token transforms bundled in a top-level `transforms` array on /proxy/sync, but the proxy's SyncResponse had no such field, so TransformsFromSync only emitted allowlist and secrets. All three transform types — oauth_token included — were dropped in managed mode at both startup and every reload. Plumb the `transforms` array through SyncResponse, SyncUpdate, and TransformsFromSync, appending it after allowlist+secrets so body-mutating secret swaps land before hmac_sign signs the body.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The control plane delivers
gcp_auth,hmac_sign, andoauth_tokentransforms bundled in a top-leveltransformsarray on/proxy/sync, but the proxy'sSyncResponsehad no such field, soTransformsFromSynconly ever emittedallowlistandsecrets. All three transform types —oauth_tokenincluded — were silently dropped in managed mode at both startup and every reload.This plumbs the
transformsarray throughSyncResponse,SyncUpdate, andTransformsFromSync, appending it afterallowlist+secretsso a body-mutating secret swap lands beforehmac_signsigns the body (matching the canonical ordering iniron-proxy.example.yaml). The transform types are already blank-imported, sobuildPipelineconstructs them by name with no further changes.