feat(postgres): allow multi-statement queries that pass the role policy#168
Merged
Conversation
Replace the statement-count rejection with per-statement classification.
A multi-statement Simple Query is now forwarded as long as every
statement passes the role policy; the batch is rejected if any statement
mutates the role (SET ROLE / set_config('role',...)) or is a DO block.
The wire relay is unchanged: the Query passthrough already forwards the
whole message and serverToClient already streams back multiple result
sets, so the upstream runs the batch as one implicit transaction.
Removes the now-unused OpMulti / RejectMultiStatement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the statement-count rejection in the Postgres proxy with per-statement classification. A multi-statement Simple Query is now forwarded as long as every statement passes the role policy; the batch is rejected if any statement mutates the role (
SET ROLE/set_config('role', ...)) or is a DO block. The wire relay is unchanged since theQuerypassthrough already forwards the whole message and multiple result sets already stream back, so the upstream runs the batch as one implicit transaction. Removes the now-unusedOpMulti/RejectMultiStatement.