fix(proxy): preserve percent-encoded reserved chars in upstream path#156
Merged
Conversation
The HTTP handler built the upstream URL from r.URL.Path (already decoded), so %2F and other percent-encoded reserved characters were collapsed before the upstream request was constructed. This broke APIs like GCS that route on encoded slashes within a single path segment (e.g. /o/<object> where the object name contains slashes). Construct the upstream URL via url.URL with both Path and RawPath set so EscapedPath preserves the original encoding through the upstream RoundTrip. Fixes #155.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HTTP handler built the upstream URL from
r.URL.Path(already decoded), so%2Fand other percent-encoded reserved characters were collapsed before the upstream request was constructed. This broke APIs like GCS that route on encoded slashes within a single path segment (e.g./o/<object>where the object name contains slashes). The fix constructs the upstream URL viaurl.URLwith bothPathandRawPathset soEscapedPathpreserves the original encoding end-to-end.Audited existing transforms: oauth/gcpauth/awsauth/hmacsign only read
URL.Path; token_broker_resolver builds its own URL withRawPathset; secretsswapPathclearsRawPathafter substitution, which is fine for placeholder tokens but would re-encode a coexisting%2Fin the same path (narrow edge case, predates this fix).Fixes #155.