refactor: centralize case-sensitive header handling in internal/headers#153
Merged
Conversation
Promote the case-preservation helpers out of internal/transform into a dedicated internal/headers package, expand the API to cover bulk-apply and swap-with-wire-casing, and migrate every call site that previously inlined direct http.Header map assignment (broker/refresh, oauth grant transport, secrets inject + swap, hmacsign). The "why bypass Set" comment now lives in exactly one file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes the case-preservation header helpers out of
internal/transforminto a dedicatedinternal/headerspackage, expands the API to cover bulk-apply and swap-with-wire-casing, and migrates every call site that previously inlined directhttp.Headermap assignment (broker/refresh, oauth grant transport, secrets inject + swap, hmacsign). The "why bypass Set" comment now lives in exactly one file.