fix(ci): always log in to Docker Hub on release tags#147
Merged
Conversation
The prerelease guard `!contains(github.ref, '-')` always evaluated false for iron-token-broker tags because the ref prefix itself contains a dash, silently skipping the Docker Hub login. Drop the guard on both jobs so prerelease tags also push images, and gate the `latest` Docker tag on `.Prerelease` in the goreleaser configs so RC builds don't clobber it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The prerelease guard
!contains(github.ref, '-')always evaluated false for iron-token-broker tags because the ref prefix itself contains a dash, so the Docker Hub login step was silently skipped on every broker release. Dropped the guard on both jobs so prereleases also push, and gated thelatestDocker tag on.Prereleasein both goreleaser configs so RC builds don't clobber it.