refactor(secrets): drop env-name overrides for 1password and 1password_connect#144
Merged
Merged
Conversation
…nnect The 1password_connect source and broker store always read OP_CONNECT_HOST and OP_CONNECT_TOKEN from the environment; the overrides were never used and added config surface for no benefit.
Match the 1password_connect cleanup: the 1password source and broker store always read OP_SERVICE_ACCOUNT_TOKEN from the environment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
host_envandtoken_envconfig knobs from the1passwordand1password_connectsources (and matching broker stores). These overrides were never used in practice; the SDK conventions (OP_SERVICE_ACCOUNT_TOKEN,OP_CONNECT_HOST,OP_CONNECT_TOKEN) are now hardcoded. Per-env-name client caches collapse to a single lazily-built client.