Rework executor callback data#50
Merged
irobot-ros merged 7 commits intoirobot-ros:irobot/add-events-executorfrom Mar 11, 2021
Merged
Rework executor callback data#50irobot-ros merged 7 commits intoirobot-ros:irobot/add-events-executorfrom
irobot-ros merged 7 commits intoirobot-ros:irobot/add-events-executorfrom
Conversation
added 7 commits
February 26, 2021 16:34
irobot-ros
approved these changes
Mar 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Group callback data types under a single struct:
A
void *of this struct is passed down from rclcpp to the rmw, and is used as argument for the listeners callback.The executor cast it back and uses it to push the correspoding event to the queue.