remove smart pointer definitions for virtual class#48
Merged
irobot-ros merged 1 commit intoirobot/add-events-executorfrom Feb 22, 2021
Merged
remove smart pointer definitions for virtual class#48irobot-ros merged 1 commit intoirobot/add-events-executorfrom
irobot-ros merged 1 commit intoirobot/add-events-executorfrom
Conversation
Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com>
Collaborator
|
No reason, and also does not make sense to have a smart pointer definition for a pure virtual class. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alberto Soragna alberto.soragna@gmail.com
This smart pointer definition caused a compilation error when building with clang 7, due to event waitable class being pure virtual (it inerhits from pure virtual waitable and does not implement execute)
any reason to keep it @mauropasse ?