Skip to content

R4R: Add rewards query#1360

Merged
wukongcheng merged 4 commits intoirisnet:release0.13from
chengwenxi:reward-query
Mar 18, 2019
Merged

R4R: Add rewards query#1360
wukongcheng merged 4 commits intoirisnet:release0.13from
chengwenxi:reward-query

Conversation

@chengwenxi
Copy link
Contributor

No description provided.

@HaoyangLiu
Copy link

How about add querier interfaces in distribution module? You can refer to F1 distribution implementation.

@chengwenxi
Copy link
Contributor Author

How about add querier interfaces in distribution module? You can refer to F1 distribution implementation.

Will add querier interfaces and refactor all the distribution query API in next version, but the modification is too big for this version.

@chengwenxi chengwenxi changed the title WIP: Add rewards query R4R: Add rewards query Mar 18, 2019
@wukongcheng
Copy link
Contributor

It seems that this query interface will consume more calculation resources then others.

@chengwenxi
Copy link
Contributor Author

It seems that this query interface will consume more calculation resources then others.

Yes, so we'd better to refactor all the query API by adding querier interfaces in modules.

wukongcheng
wukongcheng previously approved these changes Mar 18, 2019
@chengwenxi chengwenxi changed the title R4R: Add rewards query WIP: Add rewards query Mar 18, 2019
@chengwenxi chengwenxi changed the title WIP: Add rewards query R4R: Add rewards query Mar 18, 2019
@chengwenxi chengwenxi requested review from haifengxi and wukongcheng and removed request for wukongcheng March 18, 2019 05:58
@wukongcheng wukongcheng merged commit 438ca5d into irisnet:release0.13 Mar 18, 2019
@chengwenxi chengwenxi deleted the reward-query branch March 21, 2019 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants