-
Notifications
You must be signed in to change notification settings - Fork 857
Closed
Labels
codegen/llvmLLVM code generation compiler backendLLVM code generation compiler backend
Description
We need to migrate, ideally before our LLVM integrate process catches up to the default change (llvm/llvm-project@946f803) and definitely before the support is fully removed from LLVM/MLIR (4 weeks from now).
Related (for LLVM, not MLIR): #9319
See
- https://discourse.llvm.org/t/psa-in-tree-conversion-passes-can-now-be-used-with-llvm-opaque-pointers-please-switch-your-downstream-projects/68738
- https://discourse.llvm.org/t/psa-conversion-to-llvm-passes-now-emit-opaque-pointers-by-default/69125
We have uses of LLVMTypeConverter that are currently relying on the default of options.useOpaquePointers = false;, and many lit tests that use the typed pointer IR syntax (e.g. !llvm.ptr<i32> instead of !llvm.ptr).
We are definitely affected, as naively switching in ConvertToLLVM.cpp results in errors like this:
[build] D:/dev/projects/iree/tests/e2e/linalg/conv2d.mlir:2:13: error: 'llvm.insertvalue' op Type mismatch: cannot insert '!llvm.ptr<f32>' into '!llvm.struct<(ptr, ptr, i64, array<4 x i64>, array<4 x i64>)>'
[build] %inputs = util.unfoldable_constant dense<[[[
[build] ^
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
codegen/llvmLLVM code generation compiler backendLLVM code generation compiler backend