Feedback on #5824 by inteon · Pull Request #1 · irbekrm/cert-manager

inteon · 2023-03-28T12:07:16Z

combined feedback for cert-manager#5824, includes:

change interface of SecretNamespaceLister: adding context.Context & all resulting changes
handle the case where the provided namespace != the namespace provided to the indexer (using cli flag)
simplify the List function
use same type of errors everywhere in Get and List functions

internal/informers/core_filteredsecrets.go

Signed-off-by: irbekrm <irbekrm@gmail.com> Co-authored-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>

Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>

inteon mentioned this pull request Mar 28, 2023

Controller partial metadata cert-manager/cert-manager#5824

Merged

irbekrm reviewed Mar 29, 2023

View reviewed changes

internal/informers/core_filteredsecrets.go Outdated Show resolved Hide resolved

irbekrm and others added 2 commits March 29, 2023 12:12

Code review feedback

0ca23a5

Signed-off-by: irbekrm <irbekrm@gmail.com> Co-authored-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>

feedback on 5824

7b657fa

Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>

inteon force-pushed the 5824_feedback branch from 3a1282f to 7b657fa Compare April 1, 2023 09:29

irbekrm force-pushed the controller_partial_metadata branch from 0ca23a5 to 85c766a Compare April 6, 2023 09:48

Provide feedback