execution count more atomic, run_cell_async reenterable#15088
Merged
Carreau merged 1 commit intoipython:mainfrom Dec 3, 2025
Merged
execution count more atomic, run_cell_async reenterable#15088Carreau merged 1 commit intoipython:mainfrom
Carreau merged 1 commit intoipython:mainfrom
Conversation
Member
|
I don't super like the -1 in a few places, but let's try |
Contributor
Author
|
Yeah... I tried the alternative of starting the execution count at 0 and having everything show the "current" execution_count, but other projects (e.g. ipykernel) already have their own minus ones, so the projects would have to be modified in tandem |
Member
|
It should be released :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes
run_cell_asyncable to re-enter itself without messing the history causing a new session. This solves issue #15087The changes are to increment
execution_countofInteractiveShellbefore running the user code in a cell, and some compatible changes so that prompts and outputs get the correctexecution_count.With this change it's possible to modify frontends so that they can run multiple cells concurrently. I've written a small one-file package on top of ipykernel that shows this nicely and works well
https://github.com/drorspei/bgipykernel