TST: add systematic backward compatibility checks against oldest supported versions of direct dependencies#15054
Conversation
bf7b348 to
1b496d3
Compare
|
I got the number of failed tests from 2 to 1 by bumping the minimum requirement on jedi, but I don't get what's happening with the remaining failure yet, so I don't have a good idea of which other direct dependency needs bumping to resolve it. Of course I could just try them all but that'd be wasteful, so in case it might be obvious to others, I'm open to suggestions ! |
|
@Carreau just curious, did you actually request a review from Copilot, or is GH's UI just pretending you did ? (I heard such reviews could appear un-prompted) |
|
I tried clicking on it to see if it could find or suggest the root cause of the test failure, but it just summarized the PR... So yes the noise was due to me, sorry about that. |
|
Did you ping me for the completion XFAILs? These are expected. I see a real issue with |
|
It was about that test yes. Do you have any idea what direct dependency would be affect the outcome ? |
|
Well, the failure looks like could be due to formatting of cPython copyright message so maybe |
|
This is supposed to check the viability of an environment barely matching minimal requirements as declared in pyproject.toml |
|
The fact that the job is currently failing necessarily indicates that at least one minimal requirement needs to be updated. I just don't know where to look first. |
95023ae to
a83d503
Compare
|
Well, I would bump python-version first :P |
|
After a couple iterations, I found, empirically, that bumping |
a83d503 to
fc63d86
Compare
|
FTR; bumping Python to 3.12 wouldn't have solved this failure. |
fc63d86 to
a7d5d2c
Compare
Follow up to #15041
Since this setup requires uv (pip install doesn't support the
--resolutionargument, crucial to this work), I've written it as a completely separate job instead of a matrix item. It would be possible to reconcile the two, but that would make for a much more invasive change where I'd replace pip with uv everywhere. Of course, if that's desired, I'm also happy to go all-in with uv, either here, or as a follow up PR.