Closed
Conversation
I see no difference in e.g. Jupyter notebook. Removing this call prevents the unnecessary installation of a gui event loop hook.
shaperilio
commented
May 2, 2023
| from matplotlib_inline.backend_inline import configure_inline_support | ||
| # NOTE: this import triggers `enable_gui('qt')` and occurs before the users' config (e.g. | ||
| # `--matplotlib=qt5`) is procssed. | ||
| # from matplotlib_inline.backend_inline import configure_inline_support |
Contributor
Author
There was a problem hiding this comment.
Removing this import (and the function call that requires it) prevents the unnecessary installation of a qt event loop hook, and as far as I can tell, has no negative effects - I still get inline figures in a Jupyter notebook, for example. I'll need someone with more expertise to chime in on this.
This reverts commit 765ddb3; still need two else statements anyway.
Consider making this a query, and make a `%gui off` actually remove it
Member
|
Closing old stale PRs, sorry if this was not addressed, but this has been a few years, so there are few chances of someone actually pushing this through. Feel free to resubmit if you feel this has a chance to be revived. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the annoying extra messages as detailed in #14006.
Behavior
The intent is to:
'qt'hook request.Take a system with both
PyQt5andpyside6installed:This means when you run
ipython --matplotlib=tk, for example, you'll see this:Notes
Working on this has uncovered some interesting dynamics;
qtis taken to mean "the latest Qt available" and the current code appears to force, in some cases, what is effectively a%gui qtcommand before command line or config args are processed (see this issue), so that executingeffectively runs
and if both
pyside6andPyQt5are installed, the%gui qt5will trigger a message about not being able to change Qt versions in the session.