Replaced PUB socket with XPUB socket #1482
Merged
+80
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32550f8 to
8be7770
Compare
Contributor
Author
|
This needs spyder-ide/qtconsole#644 and a release of qtconsole. |
SylvainCorlay
approved these changes
Dec 25, 2025
Member
|
It's been a few weeks areadly. I propose that we disable the qtconsole downstream tests, until we hear back from the team. |
JohanMabille
added a commit
that referenced
this pull request
Jan 8, 2026
As suggested [here](#1482 (comment)), this removes the spyder downstream tests to avoid delaying more the PRs on ipykernel. Done in a dedicated PR so it's easier to retrieve this change in the history if we need to add them back at some point.
Collaborator
|
This is in the 7.2.0a0 prerelease so that is can be fully tested. |
Member
Sorry for the unresponsiveness but I'd also like to say that, even if I were available, tests in spyder-ide/qtconsole#644 are not passing, so I couldn't merge that PR. |
Contributor
Author
|
Which test do not pass? I see every job green. |
minrk
reviewed
Jan 16, 2026
| """ | ||
|
|
||
| def __init__(self, socket, pipe=False): | ||
| def __init__(self, socket, session=None, pipe=False): |
Member
There was a problem hiding this comment.
Since this is a breaking API change, let's make sure this is a major version bump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the XPUB JEP in ipykernel.