Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #191 +/- ##
=======================================
Coverage 99.88% 99.88%
=======================================
Files 5 5
Lines 839 839
Branches 109 109
=======================================
Hits 838 838
Misses 1 1 |
04e6c98 to
e440844
Compare
041b17d to
86522b8
Compare
axic
reviewed
Oct 31, 2019
| table[OP_BALANCE] = {op_balance, 700, 1, 0}; | ||
| table[OP_CHAINID] = {op_undefined, 2, 0, 1}; | ||
| table[OP_EXTCODEHASH] = {op_extcodehash, 700, 1, 0}; | ||
| table[OP_SELFBALANCE] = {op_undefined, 5, 0, 1}; |
Member
There was a problem hiding this comment.
Shouldn't this and chainid be implemented?
Member
There was a problem hiding this comment.
They are in separate PRs, it's better to merge this first, and then rebase those
gumb0
approved these changes
Oct 31, 2019
axic
approved these changes
Oct 31, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.