Skip to content

t8n: Add --opcode.count option#1274

Merged
chfast merged 1 commit into
masterfrom
test/t8n-opcode-count
Jul 29, 2025
Merged

t8n: Add --opcode.count option#1274
chfast merged 1 commit into
masterfrom
test/t8n-opcode-count

Conversation

@chfast

@chfast chfast commented Jul 21, 2025

Copy link
Copy Markdown
Member

Closes #1256.

@codecov

codecov Bot commented Jul 21, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.61905% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 87.15%. Comparing base (50eb7cb) to head (73fc381).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
test/t8n/t8n.cpp 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1274      +/-   ##
==========================================
+ Coverage   87.13%   87.15%   +0.01%     
==========================================
  Files         166      166              
  Lines       24645    24687      +42     
  Branches     4058     4064       +6     
==========================================
+ Hits        21474    21515      +41     
  Misses        534      534              
- Partials     2637     2638       +1     
Flag Coverage Δ
eest-develop 17.76% <0.00%> (-0.04%) ⬇️
eest-develop-gmp 15.77% <0.00%> (-0.03%) ⬇️
eest-fusaka 12.31% <0.00%> (-0.03%) ⬇️
eest-legacy 11.30% <0.00%> (-0.02%) ⬇️
eest-legacy-silkpre 17.78% <0.00%> (-0.03%) ⬇️
eest-static 18.81% <0.00%> (-0.04%) ⬇️
evmone-unittests 83.68% <97.61%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
core 93.36% <100.00%> (+0.03%) ⬆️
tooling 88.35% <88.88%> (+<0.01%) ⬆️
tests 84.06% <ø> (ø)
Files with missing lines Coverage Δ
lib/evmone/tracing.cpp 100.00% <100.00%> (ø)
lib/evmone/tracing.hpp 100.00% <ø> (ø)
lib/evmone/vm.cpp 97.05% <100.00%> (+0.18%) ⬆️
test/t8n/t8n.cpp 74.44% <88.88%> (+0.59%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marioevz

Copy link
Copy Markdown
Contributor

Giving it a try today 🫡

@chfast

chfast commented Jul 26, 2025

Copy link
Copy Markdown
Member Author

No worries, take as much time as you need.

@marioevz

Copy link
Copy Markdown
Contributor

Works perfectly, I spent some time trying to think if there could be a better interface but I think this should work just fine.

Link to the EEST PR that adds support to this: ethereum/execution-spec-tests#1956

@chfast chfast force-pushed the test/t8n-opcode-count branch from 279310d to 73fc381 Compare July 29, 2025 19:50
@chfast chfast merged commit ed23204 into master Jul 29, 2025
24 checks passed
@chfast chfast deleted the test/t8n-opcode-count branch July 29, 2025 20:10
@jochem-brouwer

Copy link
Copy Markdown

Does this output executed opcodes, or opcodes which might be executed (depending if enough gas is available)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: add an interface to t8n for the histogram opcode counter tracer

3 participants