Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1089 +/- ##
==========================================
+ Coverage 93.84% 94.30% +0.45%
==========================================
Files 159 159
Lines 17330 17316 -14
==========================================
+ Hits 16263 16329 +66
+ Misses 1067 987 -80
Flags with carried forward coverage won't be shown. Click here to find out more.
|
9971bd0 to
6e214c6
Compare
rodiazet
requested changes
Jan 15, 2025
Member
rodiazet
left a comment
There was a problem hiding this comment.
It's OK in general. A few nits to be fixed.
test/state/precompiles.cpp
Outdated
| static constexpr auto POINT_COSTS = | ||
| bls12_msm_discounts_to_point_costs(G1MUL_GAS_COST, DISCOUNTS); | ||
|
|
||
| if (input.empty() || input.size() % 160 != 0) |
Member
There was a problem hiding this comment.
Can we define single input size and use ut here and below? Same for G2
Member
Author
There was a problem hiding this comment.
I defined constants for sizes, but not used it &input[64]... I think the input handling may need separate improvement.
| return {EVMC_SUCCESS, 128}; | ||
| } | ||
|
|
||
| ExecutionResult bls12_g1mul_execute(const uint8_t* input, size_t input_size, uint8_t* output, |
Member
There was a problem hiding this comment.
Remove also their analysis counterparts for g1 and g2. Here and from the header.
64d0901 to
a7d3dcc
Compare
86be2af to
bf96564
Compare
rodiazet
approved these changes
Jan 20, 2025
bf96564 to
b722957
Compare
This updates the gas costs of BLS precompiles. Discounts tables for MSMs are now split between G1 and G2 variants.
Remove redundant G1/G2 MUL precompiles easily replaceable with MSMs. Spec update: ethereum/EIPs#8945.
b722957 to
fcc69b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply recent EIP-2537 spec updates: