Async Crypto Endeavour by dignifiedquire · Pull Request #4 · ipld/js-ipld-block

dignifiedquire · 2016-09-26T20:16:35Z

BREAKING CHANGE:
Constructor requires a hash now and there is now Block.create(data, type, cb)

daviddias · 2016-10-05T14:35:53Z

README.md

+
+Creates a new block with raw data `data`. `type` can be either `'protobuf'` or `'ipld'`.
+
+#### `Block.create(data, key, [type, ] callback)`


Let's just go ahead and take from #5 the fact that .key becomes a function and make it an async function.

@diasdavid done, please review the new api before I start propagating

daviddias · 2016-10-05T14:36:06Z

package.json

@@ -38,13 +38,13 @@
  "homepage": "https://github.com/ipfs/js-ipfs-block#readme",
  "devDependencies": {
    "aegir": "^8.0.0",


update to latest

daviddias · 2016-10-12T13:39:27Z

API looks good, needs:

a test that tests with a different hash func

daviddias

Overall LGTM

daviddias · 2016-10-31T10:48:09Z

README.md

    - [`block.data`](#blockdata)
-    - [`block.key`](#blockkey)
-  - [`block.extension`](#blockextension)
+    - [`block.key([hashFn,] callback)`](#blockkeyhashfn-callback)


s/hashFn/hashAlg

daviddias · 2016-10-31T10:48:28Z

README.md

-
-The [multihash][multihash] of the block's data, as a buffer.
-
+#### `block.key([hashFn,] callback)`


s/hashFn/hashAlg

daviddias · 2016-11-03T11:31:46Z

src/index.js

+    set () {
+      throw new Error('Tried to change an immutable block')
+    }
+  })


Kubuxu · 2016-11-03T11:54:58Z

src/index.js


-    multihashing(this.data, hashFunc, callback)
+    if (this._cache[hashFunc]) {
+      setImmediate(() => {


setImmediate isn't supported by FF or Chrome, will it be a problem?

hmm thanks for pointing this out, need to find a better solution :(

setImmediate is also used in 4 different places across the codebase. There is also polyfill for it if it comes to it.

yeah we were shipping one before, but not anymore. As we already use async I'm going to use async.setImmediate http://caolan.github.io/async/docs.html#setImmediate

Fixes #10

dignifiedquire added the status/in-progress In progress label Sep 26, 2016

dignifiedquire mentioned this pull request Sep 26, 2016

Awesome Async Crypto + Less magic to 'run in the browser' ipfs/js-ipfs#485

Merged

5 tasks

dignifiedquire added the needs review label Oct 3, 2016

dignifiedquire assigned daviddias Oct 3, 2016

daviddias suggested changes Oct 5, 2016

View reviewed changes

daviddias removed the needs review label Oct 12, 2016

dignifiedquire force-pushed the webcrypto branch from fa9a47f to 41fd06b Compare October 26, 2016 10:26

async crypto

7941631

dignifiedquire force-pushed the webcrypto branch from 41fd06b to 7941631 Compare October 26, 2016 10:43

dignifiedquire added the needs review label Oct 26, 2016

dignifiedquire added 3 commits October 27, 2016 12:50

ready for next aegir

a957e1e

docs: more badges

5f2ee96

update aegir

dfa623c

daviddias changed the title ~~fix: transition to async crypto api~~ Async Crypto Endeavour Oct 30, 2016

daviddias assigned dignifiedquire Oct 30, 2016

daviddias suggested changes Oct 31, 2016

View reviewed changes

daviddias removed the needs review label Oct 31, 2016

cr updates

55f6a43

daviddias approved these changes Oct 31, 2016

View reviewed changes

dignifiedquire added 2 commits November 2, 2016 13:21

ready

4faacbd

chore: update dependencies

59ce8b6

daviddias reviewed Nov 3, 2016

View reviewed changes

src/index.js

set () {

throw new Error('Tried to change an immutable block')

}

})

Copy link
Copy Markdown

Member

daviddias Nov 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Kubuxu reviewed Nov 3, 2016

View reviewed changes

feat: immutable block and cached keys

488d68c

Fixes #10

dignifiedquire force-pushed the webcrypto branch from b9f4187 to 488d68c Compare November 3, 2016 12:06

daviddias merged commit bb49479 into master Nov 3, 2016

daviddias deleted the webcrypto branch November 3, 2016 12:40

daviddias removed the status/in-progress In progress label Nov 3, 2016


		Creates a new block with raw data `data`. `type` can be either `'protobuf'` or `'ipld'`.

		#### `Block.create(data, key, [type, ] callback)`


		The [multihash][multihash] of the block's data, as a buffer.

		#### `block.key([hashFn,] callback)`

Conversation

dignifiedquire commented Sep 26, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

daviddias commented Oct 12, 2016 • edited by dignifiedquire Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

daviddias left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

daviddias commented Oct 12, 2016 •

edited by dignifiedquire

Loading