Merged
Conversation
Map/List should return an actual node type, not a pointer to a node. Otherwise, breaks when nested in other map/list type
Add a disclaimer to the header for generated code to prevent linters from complaining
Collaborator
Author
|
also includes last PR |
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
==========================================
+ Coverage 72.42% 72.43% +0.01%
==========================================
Files 50 50
Lines 3154 3155 +1
==========================================
+ Hits 2284 2285 +1
Misses 780 780
Partials 90 90
Continue to review full report at Codecov.
|
Collaborator
|
dangit my email filters are still not good enough, I missed this until now TIL also! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One more add -- a disclaimer about files being code gen'd which will cause most linters to ignore the file, avoiding lots of lint warnings :)