fix(schema/gen): return value not reference#38
Merged
Conversation
Map/List should return an actual node type, not a pointer to a node. Otherwise, breaks when nested in other map/list type
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
=======================================
Coverage 72.42% 72.42%
=======================================
Files 50 50
Lines 3154 3154
=======================================
Hits 2284 2284
Misses 780 780
Partials 90 90
Continue to review full report at Codecov.
|
Collaborator
|
Good eye. I'm mildly surprised this even compiled... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Map/List should return an actual node type, not a pointer to a node. Otherwise, breaks when nested
in other map/list type.
We use a pointer to a node when we're building nodes, for maps (so we can mod it easily I assume). However, when we actually build it, we should dereference it -- because that's the type anyone using the node expects-- and in fact things will error if you build a map inside a map.