Empty identity CID should be indexed when options are set#316
Merged
Conversation
Member
Author
There is an edge-case where if the storing identity CIDs are enabled in a CARv2, one could technically store an empty identity CID which ends up with a `singlewidthindex` width of 8. Such CAR files indeed exist out there and the validation changes introduced in `2.4.0` means such CAR file indices are no longer readable , even if regenerated. The question is should this be considered a valid index/readable index?
44f424a to
853cb36
Compare
willscott
approved these changes
Jul 6, 2022
Member
willscott
left a comment
There was a problem hiding this comment.
seems fine. not the index's problem to enforce constraints to not do silly things at other layers of the stack
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an edge-case where if the storing identity CIDs are enabled in
a CARv2, one could technically store an empty identity CID which ends up
with a
singlewidthindexwidth of 8.Such CAR files indeed exist out there and the validation changes
introduced in
2.4.0means such CAR file indices are no longer readable, even if regenerated.
The question is should this be considered a valid index/readable index?