This repository was archived by the owner on Mar 10, 2020. It is now read-only.
Conversation
alanshaw
suggested changes
May 1, 2019
Contributor
alanshaw
left a comment
There was a problem hiding this comment.
Wow 😲 ❤️ really extensive set of tests. The only thing I'd add is a sanity test with some CBOR data to ensure it's working with other IPLD formats too.
alanshaw
suggested changes
May 1, 2019
Contributor
alanshaw
left a comment
There was a problem hiding this comment.
Refs command needs tests for multiple inputs.
alanshaw
suggested changes
May 1, 2019
Contributor
alanshaw
left a comment
There was a problem hiding this comment.
Needs API docs added https://github.com/ipfs/interface-js-ipfs-core/tree/master/SPEC
dirkmc
commented
May 3, 2019
alanshaw
approved these changes
May 8, 2019
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.