Conversation
4 tasks
hacdias
commented
Feb 27, 2023
| - [`404 Not Found`](#404-not-found) should be returned when the root CID is valid and traversable, but | ||
| the DAG it represents does not include content path remainder. | ||
| - Error response body should indicate which part of immutable content path (`/ipfs/{cid}/path/to/file`) is missing | ||
| - [`400 Bad Request`](#400-bad-request) can be used for remaining traversal errors caused by invalid or unsupported DAG types. |
Member
Author
There was a problem hiding this comment.
AFAIK, 400 is removed for path resolution purposes. There are still 400s, but for other use-cases (invalid headers, invalid format requested, etc).
2 tasks
lidel
approved these changes
Feb 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See ipfs/boxo#185