refactor!: use listen address instead of port, change default #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README uses --net=host, and docs explain SOMEGUY_LISTEN_ADDRESS this also aligns with how we do things in rainbow
lidel
approved these changes
Mar 6, 2024
Member
lidel
left a comment
There was a problem hiding this comment.
lgtm, but make sure top update our infra to the new port :)
Comment on lines
-13
to
-15
| EXPOSE 8080 | ||
|
|
||
| CMD [ "/someguy", "start", "--port", "8080" ] |
Member
There was a problem hiding this comment.
ℹ️ removed defaults from Dockerfile. Rainbow did not have them, Someguy also should not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #47.
Changes default port to 8190, and changes from port to listen address config.
After this, we may need to update the infra.