feat: automatically generate peerIDs for HTTP block providers if they are not passed #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aa52f08 to
953f966
Compare
|
given that the peerIDs are vestigial this makes a lot of sense to me; I am currently calling out to some utility code to generate them and throw away the keys, which creates unnecessary external dependencies allowing SOMEGUY_HTTP_BLOCK_PROVIDER_PEERIDS to be passed keeps the API shape and allows users that do want to specify them to do so (BTW I it looks like the endpoints and peerIDs, if specified, are matched to one another in the order specified, but this is not 100% clear from the docs) |
gammazero
approved these changes
Sep 13, 2025
explain that auto-generated peerids are placeholders for http providers, not used for cryptographic operations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.