fix: expose agent-version-suffix via identify protocol#9457
Merged
Conversation
Closed
3 tasks
ajnavarro
approved these changes
Dec 6, 2022
This was referenced Dec 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #9456 and adds end-to-end test which confirms suffix is exposed over identify protocol.
Pinging bunch of folks for review / FYI.
Sad details
--agent-version-suffixintroduced in #8419 was not applied whenlibp2p.UserAgentwas initialized, which meant the suffix was always absent from libp2p's identify protocol.The result: we were not getting information about
/brave/desktopand/dockernodes :'(Good news is that Kubo 0.18.0-rc1 will have this fixed, unblocking probe-lab/network-measurements#24
TODO