Closed
Conversation
a50b925 to
fbbb080
Compare
Contributor
|
go-bitswap is used by many other pieces of software, it's also big and we don't touch it often. I don't think it's worth moving into libkubo |
Contributor
Author
|
The criteria for moving repos into libipfs isn't "unused, small, and unchanging"...the goal is to get all of our repos into one place, big and small, popular and unpopular. (Of course there will be exceptions to this, but they should be exceptions, and we should have a good practical reason for not moving them.) Also consider that part of the reason we don't touch it often is because the plumbing is painful. The tactical reason I am opening this now is because it is big and used by many other components, so it's a good stress test of the process for migrating repos into libipfs. |
fbbb080 to
977abf5
Compare
977abf5 to
1ce9a87
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.